Skip to content

Add support for rotating scene tiles in TileMapLayer #108010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DexterFstone
Copy link

Closes godotengine/godot-proposals#12570

2025-06-26.06-56-57.mp4

@DexterFstone DexterFstone requested a review from a team as a code owner June 26, 2025 14:10
@AThousandShips AThousandShips added this to the 4.x milestone Jun 26, 2025
@groud
Copy link
Member

groud commented Jun 26, 2025

Hi, thanks for the contribution. For now, sorry, I really don't want to complexify the API for that feature. The TileMapLayer API is already complex enough and I don't want to add more arguments to set_cell right now.

Maybe I'll change my mind if the proposal gets more backing, but for now it's pretty limited.

@DexterFstone
Copy link
Author

DexterFstone commented Jun 26, 2025

Hi, thanks for the contribution. For now, sorry, I really don't want to complexify the API for that feature. The TileMapLayer API is already complex enough and I don't want to add more arguments to set_cell right now.

Maybe I'll change my mind if the proposal gets more backing, but for now it's pretty limited.

Maybe I can work on it, and use different way to implement it
If the number of arguments is problem

@groud
Copy link
Member

groud commented Jun 26, 2025

Maybe I can work on it, and use different way to implement it
If the number of arguments is problem

Hmm. Maybe reusing the alternative tile ID would work, like we do with atlas tiles. Yet,I am not sure how much the feature is desired, so I'd rather have more voices to back it up too.

@DexterFstone DexterFstone force-pushed the add-scene-tile-rotation branch from b951d0d to 2e72f5a Compare June 28, 2025 14:15
@DexterFstone
Copy link
Author

DexterFstone commented Jun 28, 2025

Hmm. Maybe reusing the alternative tile ID would work, like we do with atlas tiles. Yet,I am not sure how much the feature is desired, so I'd rather have more voices to back it up too.

I updated the code, now there should be no complexity

@DexterFstone DexterFstone force-pushed the add-scene-tile-rotation branch from 2e72f5a to 95522c0 Compare June 29, 2025 14:13
@DexterFstone DexterFstone force-pushed the add-scene-tile-rotation branch from 95522c0 to dc358dd Compare June 30, 2025 11:51
@DexterFstone DexterFstone requested a review from groud June 30, 2025 11:53
@DexterFstone DexterFstone force-pushed the add-scene-tile-rotation branch 2 times, most recently from 37766da to 24b73f5 Compare June 30, 2025 12:11
@DexterFstone DexterFstone force-pushed the add-scene-tile-rotation branch from 24b73f5 to 68939c4 Compare July 1, 2025 06:17
@DexterFstone DexterFstone requested a review from groud July 1, 2025 06:20
@DexterFstone DexterFstone force-pushed the add-scene-tile-rotation branch from 68939c4 to d4b0f89 Compare July 2, 2025 09:30
@DexterFstone DexterFstone requested a review from groud July 2, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for rotating scene tiles in TileMapLayer
3 participants