Add missing JNI variant conversion for generic Array #108019
Merged
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limbonaut
changed the title
dsnopek
approved these changes
Jun 26, 2025
m4gr3d
approved these changes
Jun 26, 2025
syntaxerror247
added
the
cherrypick:4.4
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes JNI abstractions not performing variant conversion for basic Array.
The issue is described in detail here:
In short, in the sentry-godot extension, we are passing Dictionary arguments to Android Plugin methods, and any basic arrays in a Dictionary are getting lost in the process. This PR fixes the issue by adding the conversion path for
Variant::ARRAYin the_variant_to_jvalue()function insidejni_utils.cpp.Before this PR
After this PR