Gridmap editor: Avoid extra mesh instantiation when setting clipboard data #108026
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. |
|
Oops sorry, I'll fix it asap |
Fgico
force-pushed
the
gridmap-avoid-extra-clipboard-mesh-instantiation
branch
from
e3b019a to
c5a59e4
Compare
|
Fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue: Gridmap: Doing Cut operation generates a phantom tile #107996
When storing meshes in the clipboard, the selected mesh is instanced twice in a row, overwriting item.instance and leaving an extra mesh at the origin of the scene, since we lose the reference to it and it's never set to follow the selection cursor