Clean up numeric EditorProperty setup()
methods
#108065
Open
+159
−149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the numeric EditorProperty
setup()
methods are somewhat brittle. When these properties are created, they are first bundled into a struct, which is then destructed in the method call. This PR changes the signature of the numericsetup()
calls to use the struct directly. This has several benefits:setup()
calls have many seemingly arbitrary numbers and booleans that are hard to understand without looking at theeditor_properties.h
file. This change makes it clear within the file what the parameters that the code is changing.Note: In making this change I found multiple invalid calls to
setup()
, most looking like:setup(-1, 99999, true);
where there is a boolean in the third argument (which is defined asdouble p_step
). I'm not sure what the intention was originally, but making this change will prevent future invalid calls and help catch other invalid calls before they are propagated.