X11: Fix memory leak when using window embedding #108082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jun 28, 2025
| } | ||
| } | ||
|
|
||
| // Then check children of children. | ||
| for (unsigned int i = 0; i < num_children; i++) { | ||
| Window wnd = find_window_from_process_id_internal(p_display, p_process_id, children[i]); | ||
| if (wnd != 0) { | ||
| XFree(children); | ||
| return wnd; |
There was a problem hiding this comment.
What happens if children is nullptr? The code below seems to guard against that.
There was a problem hiding this comment.
num_children is the number of elements in children. Getting into the loop body means children is not null.
This is also why the line above uses children[i] directly.
akien-mga
approved these changes
Jun 28, 2025
akien-mga
added
the
cherrypick:4.4
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
childrenare not freed due to early returns.