SoftBody3D: fix transform getting out of sync with the RenderingServer #108097
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a somewhat minimal fix for issue godotengine#108090. This fixes the code so that `VisualInstance3D` still correctly receives all transform update notifications and can call `RenderingServer::instance_set_transform()` correctly. In the long run it seems like it would perhaps be better to fix `SoftBody3D` so that it calls `VisualInstance3D::set_instance_use_identity_transform(true)` rather than attempting to always reset its global transform back to the identity matrix. However, doing so is a more complex change that may have somewhat larger side-effects. I think it is possibly worth doing this in a future commit, but applying this minimal fix seems worthwhile in the interim.
AThousandShips
added
bug
topic:physics
topic:3d
cherrypick:4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat minimal fix for issue #108090.
This fixes the code so that
VisualInstance3Dstill correctly receives all transform update notifications and can callRenderingServer::instance_set_transform()correctly.In the long run it seems like it would perhaps be better to fix
SoftBody3Dso that it callsVisualInstance3D::set_instance_use_identity_transform(true)rather than attempting to always reset its global transform back to the identity matrix. However, doing so is a more complex change that may have somewhat larger side-effects. I think it is possibly worth doing this in a future commit, but applying this minimal fix seems worthwhile in the interim.