Core: Restructure sanitizers #108111
Open
Core: Restructure sanitizers #108111
+36
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Makes sense to me.
One note; we don't need to include the sanitizer interfaces everywhere. It would be possible to require sanitizer users to explicitly include when needed:
#ifdef TSAN_ENABLED
#include <sanitizer/tsan_interface.h>
#endif@akien-mga brought this up in #106867 discussions.
I personally don't have a strong opinion on this issue since it's sanitizer-build only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the build and implementation logic for sanitizers, making them more clearly and universally defined where relevant:
typedefs.hnow contains the checks/defines for sanitizers, and includes the relevant headers.SANITIZERS_ENABLEDnow automatically inferred from the previous point, no longer explicitly assigned in SCons files.__has_feature, removing the need for nested define chains on unsupported compilers.