Skip to content

[3.x] FTI - Add reset on setting toplevel #108117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

lawnjelly
Copy link
Member

Fixes #108086
Backport of #108112

Notes

  • Although reset_physics_interpolation() will cure this (as with any teleport), I think this should be fine for adding an auto-reset, I can't think of any situation where you'd want to toggle top_level and not perform a reset.
  • I've taken the opportunity to check the new SceneTree::is_fti_enabled() static function to make reset_physics_interpolation() super cheap to call when FTI is off.

@lawnjelly lawnjelly added this to the 3.7 milestone Jun 29, 2025
@lawnjelly lawnjelly requested review from a team as code owners June 29, 2025 17:25
@lawnjelly lawnjelly changed the title [3.x] FTI - Add reset of setting toplevel [3.x] FTI - Add reset on setting toplevel Jul 1, 2025
@lawnjelly lawnjelly requested review from Calinou and rburing July 1, 2025 16:51
Copy link
Member

@rburing rburing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this behavior is desired in 100% of cases.

@lawnjelly lawnjelly merged commit 2163855 into godotengine:3.x Jul 1, 2025
14 checks passed
@lawnjelly lawnjelly deleted the fti_toplevel_resets3 branch July 1, 2025 17:23
@lawnjelly
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants