Skip to content

Fix subinspector for parameter preview in visual shader editor #108119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jun 29, 2025

Currently, it's impossible to edit a texture preview parameters within visual shader editor. This is a regression from 27b7b43 (#96542)

Before fix:

test2

After fix:

test

@Chaosus Chaosus added this to the 4.5 milestone Jun 29, 2025
@AThousandShips AThousandShips requested a review from a team June 30, 2025 08:21
@Chaosus Chaosus force-pushed the vs_fix_preview_subinspector branch from e18ded5 to 9f0982d Compare June 30, 2025 12:22
@Chaosus Chaosus changed the title Fix subinspector for shader preview in visual shader editor Fix subinspector for parameter preview in visual shader editor Jun 30, 2025
@Repiteo Repiteo merged commit 3954b24 into godotengine:master Jul 4, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jul 4, 2025

Thanks!

@Chaosus Chaosus deleted the vs_fix_preview_subinspector branch July 4, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants