Skip to content

Carry editor pseudolocalization CLI option across restarts #108129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Carry editor pseudolocalization CLI option across restarts #108129

wants to merge 1 commit into from
+2 −1

Conversation

timothyqiu
Copy link
Member

This PR keeps the --editor-pseudolocalization option when spawning a new instance:

  • Project Manager / Editor restarts after certain editor settings are changed.
  • Switching between the Project Manager and the Editor.

@timothyqiu timothyqiu added this to the 4.x milestone Jun 30, 2025
@timothyqiu timothyqiu requested a review from a team as a code owner June 30, 2025 03:34
Calinou
Calinou approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

It makes sense to keep this flag across restarts, as you can only specify this on the command line and not through editor settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@timothyqiu @Calinou