Skip to content

FTI - Clear SceneTreeFTI completely on enabling / disabling. #108131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

lawnjelly
Copy link
Member

Removes any dangling objects when toggling set_enabled() for SceneTreeFTI.
These could cause crashes / errors if deleted between toggling the setting.

MRP

Run godotengine/godot-demo-projects#1223 and keep toggling physics interpolation by pressing T while firing.. the DEV_ASSERT() will hit.

Notes

  • Sorry my bad, I forgot to clear these completely when adding more lists.
  • Should be very safe, and worth doing for 4.5.
  • Also applicable in 3.x.

Copy link
Member

@rburing rburing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense, and indeed will be good for 4.5.

@Repiteo Repiteo merged commit 2336f56 into godotengine:master Jul 1, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jul 1, 2025

Thanks!

@lawnjelly lawnjelly deleted the fti_clear_all branch July 2, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants