Skip to content

Fix multimesh memory leak and edge cases #108148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beicause
Copy link
Contributor

@beicause beicause commented Jun 30, 2025

Fixes:

  • Indirect draw command buffer memory leak
  • GPU out of memory if use_indirect=true and multimesh_set_visible_instances(rid, -1)
  • GPU out of memory if multimesh_allocate_data(rid, 1) and then multimesh_allocate_data(rid, -1)

And:

  • Simplify setting vertex count in the command buffer (follow-up to the 2nd in 99455#comment)
  • Follow the visible instance count rather than making all instances invisible, after setting a mesh with indirect drawing

@beicause beicause requested a review from a team as a code owner June 30, 2025 20:03
@beicause beicause force-pushed the multimesh-api-edge-cases branch 4 times, most recently from bb32e81 to 931eb9b Compare June 30, 2025 22:37
@beicause beicause force-pushed the multimesh-api-edge-cases branch from 931eb9b to cdb8c61 Compare June 30, 2025 22:43
@Calinou Calinou added bug topic:rendering cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Jun 30, 2025
@Calinou Calinou added this to the 4.5 milestone Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release topic:rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants