Add CameraServer feeds_updated signal, and document async behavior
#108165
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiena
force-pushed
the
feature/improve-camera-server
branch
from
eba8332 to
36446f6
Compare
shiena
force-pushed
the
feature/improve-camera-server
branch
2 times, most recently
from
a5aa0f3 to
3792213
Compare
adamscott
changed the title
CameraServer.monitoring_feeds race condition and document async behavior
shiena
force-pushed
the
feature/improve-camera-server
branch
from
3792213 to
72aee69
Compare
…behavior - Add SafeFlag to prevent concurrent camera thread initialization - Set monitoring_feeds to true only after device enumeration completes - Document that monitoring_feeds requires waiting a few frames - Add code examples for GDScript and C# showing proper usage pattern This ensures camera feeds are properly initialized before being accessed and prevents potential crashes from concurrent thread creation.
shiena
force-pushed
the
feature/improve-camera-server
branch
from
72aee69 to
f905263
Compare
Ivorforce
reviewed
Jul 3, 2025
shiena
force-pushed
the
feature/improve-camera-server
branch
from
f120205 to
5a6d1ea
Compare
shiena
force-pushed
the
feature/improve-camera-server
branch
from
733ff30 to
28431d0
Compare
Ivorforce
reviewed
Jul 3, 2025
modules/camera/camera_linux.cpp
Outdated
| @@ -169,12 +171,16 @@ inline void CameraLinux::set_monitoring_feeds(bool p_monitoring_feeds) { | |||
|
|
|||
| CameraServer::set_monitoring_feeds(p_monitoring_feeds); | |||
| if (p_monitoring_feeds) { | |||
| camera_thread.start(CameraLinux::camera_thread_func, this); | |||
| if (!activating.is_set()) { | |||
There was a problem hiding this comment.
This isn't fully thread safe. But I'm noticing on reviewing SafeFlag that it's improperly implemented, and cannot be made truly thread safe. For the moment, this is probably fine. I'll address my SafeFlag concerns some other time.
Ivorforce
reviewed
Jul 3, 2025
Ivorforce
changed the title
CameraServer.monitoring_feeds race condition and document async behaviorCameraServer feeds_updated signal, and document async behavior
Ivorforce
reviewed
Jul 3, 2025
This was referenced Jul 3, 2025
shiena
force-pushed
the
feature/improve-camera-server
branch
from
62e4dfc to
3a3f3c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #108136
This ensures camera feeds are properly initialized before being accessed and prevents potential crashes from concurrent thread creation.