GDScript: Don't get invalid dictionary key during completion #108167
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnen
force-pushed
the
gdscript-fix-getting-invalid-dict-key-completion
branch
from
c1031c2 to
a44885e
Compare
This allows users to call this function to check if a key is set without having to worry about checking types, which is quite cumbersome currently.
We try to get the value out of a dictionary in order to establish its type for completion purposes. However, if the dictionary or the key is not a constant, we cannot safely get the actual value, so we skip this and just try to infer from static typing.
vnen
force-pushed
the
gdscript-fix-getting-invalid-dict-key-completion
branch
from
a44885e to
7cf8e5d
Compare
Ivorforce
reviewed
Jul 2, 2025
| @@ -217,14 +217,12 @@ bool Dictionary::is_empty() const { | |||
|
|
|||
| bool Dictionary::has(const Variant &p_key) const { | |||
| Variant key = p_key; | |||
| ERR_FAIL_COND_V(!_p->typed_key.validate(key, "use 'has'"), false); | |||
There was a problem hiding this comment.
This sort of makes sense to me, but it's kind of inconsistent with the rest of the API.
I'd rather add a function like const ContainerTypeValidate &get_key_validator(), and allow querying it if the given key is compatible. Something like that, anyway.
In any case, this change should be run by the core meeting, I think.
|
Following the core meeting, here's my suggestion:
const ContainerTypeValidate &get_key_validator();
const ContainerTypeValidate &get_value_validator();
bool can_validate_variant(const Variant &p_variant) const
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to get the value out of a dictionary in order to establish its type for completion purposes. However, if the dictionary or the key is not a constant, we cannot safely get the actual value, so we skip this and just try to infer from static typing.
Note
This also adds a change in core: it removes type validation from
Dictionary.has()(andhas_all()) because it simplifies checking if a given key is valid without having to check its type externally.Fix #102926
Supersedes #104757