Allow moving nodes when they have different parents in SceneTreeDock #108168
+7
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikitf777
force-pushed
the
move-nodes-with-different-parents
branch
from
52be765 to
c609f37
Compare
Nikitf777
force-pushed
the
move-nodes-with-different-parents
branch
from
c609f37 to
cde07bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously SceneTreeDock didn't allow to move selected nodes up and down (Ctrl + Up/Down by default) when they have different parents. The code suggests that this was intentional, but I don't like it. I don't see any issues with moving nodes with different parents.
So to implement this, I just removed the limitation that was there before. Also, to get selected nodes it uses now
get_full_selected_node_list)instead ofget_top_selected_node_list(), so you can move a node and its children at the same time. This is the only change I'm not sure about. But right now I would prefer this approach over the previous one.move-nodes-with-different-parents.mp4