Use ProjectSettings path functions instead of hard-coded folder names in tests #108170
+10
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was grepping through the codebase to find the helper function that returns
res://.godot/editor
was, and didn't find these parts of the codebase when I searched for".godot"
since the actual constant is"godot"
. Once I found it, I thought it would be nice to have comments here, so that people can grep for these strings to find it. Then, I realized that my search for".godot"
led me to two places in the tests where this is hard-coded, so I replaced those.While making this PR, I also noticed that
DirAccess::make_dir_recursive
doesn't properly handleres://
paths, so I have to callProjectSettings::globalize_path
first, but I wonder if that's a bug and DirAccess should be fixed?