Move Web export threads options out of variant mk2 #108172
Merged
+17
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
approved these changes
Jul 9, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR must be merged for 4.5 because otherwise, it will introduce a breaking compatibility issue for exports in 4.6.
Note
Supersedes #107429 (mk1)
The text below is copy/pasted from mk1, because it's the same PR, but using the third property of
ExportOptionthat update visibility.This PR moves the newly added (by #104458)
variant/emscripten_pool_sizeandvariant/godot_pool_sizetothreads/emscripten_pool_sizeandthreads/godot_pool_size. It also adds the functionality to make the threads option only appear if threads are enabled. (a future PR will hide more data, i.e. PWA options only if it's enabled)Enregistrement.d.ecran.le.2025-06-11.a.18.26.43.mov
The issue stems of having 2 options prominently featured only for thread builds. This is bad, as most of Godot exports are expected to be single-threaded.