GDScript: More reliably detect cyclic inheritance in script classes #108182
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squk
changed the title
|
I would recommend posting a clear before-and-after of the error. This is so simple, but could easily get spotlighted in a release dev blog for GDScript. I have seen Redditor's burned by this because they couldn't figure out where the cyclic dependency was coming from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution :) Trying to debug why the editor doesn't display properties for some script base classes and I managed to get this change working.
Different GDScript instances can refer to the same logical GDScript, so comparing pointer values is not reliable.
This change also includes the inheritance chain as a part of the error message.
(There seems to be some race at load time. Prior to this change, I only get the error message in ~2/10 editor runs vs 10/10 with a build using these changes)
Error message before this change:
ERROR: Cyclic inheritance in script classAfter:
ERROR: Cyclic inheritance in script class: SwitchBase -> Entity -> SwitchBase