Propagate Tween.kill() to subtweens #108227
Open
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meorge
force-pushed
the
bugfix/kill-subtweens
branch
from
60135bd to
7449928
Compare
Meorge
changed the title
Meorge
force-pushed
the
bugfix/kill-subtweens
branch
from
7449928 to
45460bf
Compare
Meorge
force-pushed
the
bugfix/kill-subtweens
branch
from
45460bf to
4e82bde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with tween/subtween logic I noticed while investigating another issue. Previously, when a tween was killed with
kill(), if it had subtweens in it that hadn't yet been run, those subtweens would never be executed, but would also never be explicitly killed or made invalid. As a result, if user code was monitoring the status of a subtween (say, waiting for it to be killed or finished), they would end up waiting forever.With this PR, a
kill()call on a Tween is passed down to all of its subtweens as well, ensuring that they are all marked as dead/invalid.Note
Previously this PR also cleared subtweens when
clear()was called on the parent. As I thought it through more I realized this didn't make sense, so I removed that but kept thekill()behavior.