Fix image download example code #108230
Merged
Fix image download example code #108230
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using "https://placehold.co/512" as the url will cause image.load_png_from_buffer(body) to throw ERR_FILE_CORRUPT, need to specify that it's a png file in the url.
timothyqiu
approved these changes
Jul 3, 2025
AThousandShips
changed the title
AThousandShips
added
cherrypick:4.3
Mickeon
reviewed
Jul 3, 2025
| @@ -90,7 +90,7 @@ | |||
| http_request.request_completed.connect(self._http_request_completed) | |||
|
|
|||
| # Perform the HTTP request. The URL below returns a PNG image as of writing. | |||
There was a problem hiding this comment.
This comment on both the GDScript and C# example is quite redundant, especially now that the extension is specified in the passed URL.
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using "https://placehold.co/512" as the url will cause image.load_png_from_buffer(body) to throw ERR_FILE_CORRUPT, need to specify that it's a png file in the url.