Fix crash in Jolt Physics when switching scenes in editor #108239
Merged
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jorrit Rouwe <[email protected]>
jrouwe
approved these changes
Jul 3, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the crash (and performance degradation) shown in this MRP, and arguably fixes the most pressing part about #107951, but does not fix the issue as a whole.
This makes it so that Jolt's broad phase gets cleaned up (i.e. quadtree nodes made available) whenever a scene is emptied out completely, like it is when switching scenes in the editor, meaning we get a full "reset" on such scene switches, which should prevent us from running out of broad phase nodes and crashing.
This also cherrypicks jrouwe/JoltPhysics#1682 in order to fix a bug in
JPH::PhysicsSystem::OptimizeBroadPhasethat would otherwise prevent this from working.CC @jrouwe