Skip to content

NavMap3D: check if obstacles have avoidance enabled #108281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmlary
Copy link
Contributor

@dmlary dmlary commented Jul 4, 2025

In NavMap3D::_update_rvo_obstacles_tree_2d() check if the NavObstacle3D has avoidance enabled before adding it to the tree.

fixes #108259

In `NavMap3D::_update_rvo_obstacles_tree_2d()` check if the
`NavObstacle3D` has avoidance enabled before adding it to the
tree.

fixes godotengine#108259
@dmlary dmlary requested a review from a team as a code owner July 4, 2025 15:19
@AThousandShips AThousandShips added this to the 4.5 milestone Jul 4, 2025
@AThousandShips AThousandShips added cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jul 4, 2025
@AThousandShips
Copy link
Member

This should probably be done in the 2D code as well:

// The following block is modified copy from RVO2D::AddObstacle()
// Obstacles are linked and depend on all other obstacles.
for (NavObstacle2D *obstacle : obstacles) {
const Vector2 &_obstacle_position = obstacle->get_position();
const Vector<Vector2> &_obstacle_vertices = obstacle->get_vertices();

But only part of this PR would be cherry-pickable to 4.4 and earlier (it would need to be done manually)

@dmlary
Copy link
Contributor Author

dmlary commented Jul 4, 2025

This should probably be done in the 2D code as well

@AThousandShips I can open a separate PR for the 2D work to make it easier to cherry-pick which is needed.

@AThousandShips
Copy link
Member

This won't be possible to automatically cherry-pick as the files have moved, but that would still help

@Repiteo Repiteo merged commit 9d917f4 into godotengine:master Jul 7, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jul 7, 2025

Thanks! Congratulations on your first merged contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release topic:navigation topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavigationObstacle3D.avoidance_enabled = false does not allow NavigationAgent3D to pass
4 participants