[4.3] GLTF: Fix nasty bug with incorrect buffer indices #108304
Draft
+225
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
4.3-gltf-buffer-nasty
branch
from
156029d to
2a1bbb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR manually backports PR #108302 to the 4.3 branch since it couldn't be done automatically, and the 4.4 manual backport PR #108303 also couldn't be cherrypicked to 4.3 automatically. I also backported PR #107193 and PR #103303 as well since they both overlap with the same code and they were pending backport anyway.
Draft because PR #108302 has not been merged yet.