Skip to content

Move 2D and 3D particle editors to the 2D and 3D folders #108368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

aaronfranke
Copy link
Member

Follow-up to PR #104696. This PR moves the 2D and 3D particle editors into the new 2D and 3D folders. Previously, the 2D particle editors, 3D particle editors, and general shared code was all in one file (well, two, .h and .cpp).

This PR doesn't undo PR #94371, the code is still unified, with the 2D and 3D editors each inheriting the general base class, just now the 2D and 3D parts are organized into the 2D and 3D folders.

Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense

@KoBeWi KoBeWi requested a review from QbieShay July 7, 2025 10:01
Copy link
Contributor

@QbieShay QbieShay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Repiteo Repiteo merged commit 22721a8 into godotengine:master Jul 9, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jul 9, 2025

Thanks!

@aaronfranke aaronfranke deleted the editor-particles-2d-3d branch July 9, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants