[Web] Fix sample playback deletion and AudioStreamPolyphonic issue
#108384
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
commented
Jul 7, 2025
Comment on lines
+1625
to
+1633
| LocalVector<Ref<AudioSamplePlayback>> sample_playbacks_to_remove; | ||
| for (Ref<AudioSamplePlayback> &sample_playback : sample_playback_list) { | ||
| if (!is_sample_playback_active(sample_playback)) { | ||
| sample_playbacks_to_remove.push_back(sample_playback); | ||
| } | ||
| } | ||
| for (Ref<AudioSamplePlayback> &sample_playback_to_remove : sample_playbacks_to_remove) { | ||
| sample_playback_list.erase(sample_playback_to_remove); | ||
| } |
There was a problem hiding this comment.
Is there a better way to remove elements from the currently looping for loop list?
There was a problem hiding this comment.
Just loop with an index instead of range-based for, and start with the last element.
adamscott
force-pushed
the
fix-sample-deletion
branch
from
ba3f244 to
6e48c8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes sample playback deletion, as samples were never flagged as deleted.
This also fixes #103311 as samples were marked as active, but never marked as inactive, filling up the polyphonic playback without any way to make space.
Note
A commit will follow to inverse the flow: instead of polling JavaScript to know if a sample is active or not, I'll create a callback for JavaScript to notify Godot directly when a sample was deleted.