Skip to content

Remove unnecessary newlines from key tooltip #108404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 8, 2025

These newlines are applied onto last line of the tooltip and aren't visible (luckily tooltips ignore trailing newlines).
And that aside, they shouldn't be even part of the translated string, but outside, like in the parts above.

@KoBeWi KoBeWi added this to the 4.5 milestone Jul 8, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner July 8, 2025 12:21
@AThousandShips
Copy link
Member

The other cases feature trailing newlines as well, except for TYPE_VALUE, might be good to clean all even though the translated string cases are the most critical as they're not just not rendered but affect the translation strings (though not critically)

@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 8, 2025

Ok, I deleted other newlines too.
I originally noticed the invalid strings on Weblate, hence I only handled the translated ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants