Fix circular dependencies between libraries

[simpkins]

Fix circular dependencies between libraries

This merges the libraries from scene/, core/ drivers/, servers/, main/,
editor/, platform/, modules/, and tests/ into a single library.

Each of these directories includes code from the others, so trying to
build them as separate libraries causes problems, because they all
circularly depend on each other. I'm sort of surprised that the build
has worked up until now, given that code in core/ depends on symbols
from modules/, scene/ and servers/.

This fixes #108429, and is needed to help unblock #108415.

[adamscott]

What's the issue currently? And what does your PR do? Can you add a little bit more detail to your description?

[simpkins]

What's the issue currently? And what does your PR do? Can you add a little bit more detail to your description?

This is a draft PR that is not intended to be reviewed. I am using it just to kick off CI workflows to test builds on all the platforms.

That said, the commit messages do have more complete descriptions, and #108429 and #108415 are other relevant issues and PRs involved.

[simpkins]

Actually, now that I think I've got things working on all platforms, I will go ahead and re-use this PR to submit just the changes needed to fix the circular dependencies.

[simpkins]

Note that thirdparty_obj is added to env.core_sources above on line 163, so removing this explicit env.Depends() should not have any effect.

[Repiteo]

I'm sort of surprised that the build has worked up until now, given that code in core/ depends on symbols from modules/, scene/ and servers/.

Out of curiosity: how did you go about finding these? Was it from the compile errors alone, or is there an SCons command/tool you used? I've tried using the latter with --tree, but it was always waaay too much to parse in any meaningful way

[simpkins]

Out of curiosity: how did you go about finding these? Was it from the compile errors alone, or is there an SCons command/tool you used? I've tried using the latter with --tree, but it was always waaay too much to parse in any meaningful way

Initially some of it was just from the build errors while working on #108415, but then I just did a pretty dumb grep to look for includes that shouldn't be there. e.g. rg '#include "(main|modules|scene|servers)/' core
(You can use grep -Er instead of rg if you don't have ripgrep installed.)

Grepping for all the includes and sorting the results by include path is also helpful to look for things that shouldn't be there:

rg '#include' core | awk -F : '{ print $2 " : " $1 }' | sort