Fix some Text Editor theme issues and clean up #108463
Open
+370
−430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reload Theme
, it did not seem to work at all. It was probably broken since Usecheck_changed_settings_in_group()
everywhere #69032, sinceEditorSettings::load_text_editor_theme()
emitted the signal without marking the settings as changed, but it could be from earlier.Save Theme
menu option. It was not very useful because if you are on a loaded theme, then the file content is already the same. And if you change any theme setting in EditorSettings it switches toCustom
theme which always directs you to theSave Theme as...
option.Import theme
now also immediately switches to the new theme. This is because if you don't know that it is copying a file to the themes directory, it gave no feedback that it worked.color_theme
, it removed the revert button for it unnecessarily and it didn't persist after restart anyway.color_theme
now works. Note that if you do override it if you want to change any other colors, you will need to manually set the override toCustom
or override the colors, as the EditorSettings values for them will be reverted.THEME_SAVE
made theTHEME_SAVE_AS
option have the same value as another.Documentation
[codeblock]
instead of[code]
. This is because it has syntax highlighting in the editor, and it is useful to see the effects right there.