CodeEditor: Make possible to select and copy error text

[dalexeev]

• Closes Add an ability to copy code hints in errors godot-proposals#6998.
• Closes Improve readability of GDScript errors godot-proposals#9551.

• Replace Label with RichTextLabel, enable selection and context menu.
  • This also removes horizontal scrolling.
• Replace unnecessary includes with forward declaration.
• Remove unnecessary overrides in _update_text_editor_theme().

[MewPurPur]

Very cool, but the reduction of space is concerning me. In this case maybe it's okay, as there won't be another useful thing to add there, but the error preview is becoming too small and I wonder if we can do anything about it.

[dalexeev]

We could make the button appear only when hovering over the bottom bar. Or alternatively replace the Label with RichTextLabel and enable text selection.

[Calinou]

• Remove scrolling. Display ellipsis and tooltip instead.

Unfortunately, this is not friendly to touch inputs (for the Android editor).

We could make the button appear only when hovering over the bottom bar. Or alternatively replace the Label with RichTextLabel and enable text selection.

This would be my preferred alternative, so we can use rich formatting in the long run. This way, we can use a proportional font for the error message and use the code font for text between backticks.

[dalexeev]

Yes, I like it better too. The copy button is more obvious, but I think users will figure it out. Horizontal scrolling can be removed without clipping the text. I have updated the PR and the first post.

[Calinou]

Could a similar change be made to the error text displayed when hitting a breakpoint, script error or assertion? It's currently not selectable, although there is a button to copy it on the right edge (not easy to see on a 4K monitor at 100% scaling).

[dalexeev]

For some reason Select All doesn't work. But in the Output Log it works.

Looks like it's a RichTextLabel bug, Select All doesn't work if there are no line breaks.

assert(false, "Doesn't work.")
assert(false, "It works.\n")

[Calinou]

Tested locally on Linux (rebased on top of master f5696c3). In the script, shader editors, and debugger stack trace panel:

• The Select All action works correctly (and you can press Ctrl + C afterwards to copy).
• The Copy action does nothing even if I try it several times.

[dalexeev]

This is especially useful after #82952:

[Calinou]

Tested locally, there's an issue if you resize the editor window to be narrow:

It's better at slightly wider widths:

I would probably make it so it can't wrap over more than 3 lines.

Also, right-clicking the error message and choosing Copy has no effect if no text is selected. (This is why I had the impression the option had no effect for the longest time.) This is an issue with the RichTextLabel context menu, so we should look into addressing it in a separate PR.

Overall, I agree with the decision to use RichTextLabel as it'll allow to use rich formatting in the future (e.g. use a code font for text between backticks, and a regular font otherwise).

[dalexeev]

I would probably make it so it can't wrap over more than 3 lines.

Done.

[kitbdev]

Works as expected.

[akien-mga]

Thanks!