Skip to content

GDScript: Fix call hint appearance for complex callees #93429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Jun 21, 2024

The editor and documentation display incorrect call hints if callee is a more complex expression than just an identifier.

@dalexeev dalexeev added this to the 4.3 milestone Jun 21, 2024
@dalexeev dalexeev requested a review from a team as a code owner June 21, 2024 13:33
@dalexeev dalexeev force-pushed the fix-method-signature-appearance branch 2 times, most recently from e41ecba to 67e70cf Compare June 21, 2024 13:53
@dalexeev dalexeev modified the milestones: 4.3, 4.4 Jul 24, 2024
@dalexeev dalexeev added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Jul 24, 2024
@dalexeev dalexeev marked this pull request as draft February 16, 2025 19:48
@dalexeev dalexeev removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Feb 16, 2025
@dalexeev dalexeev modified the milestones: 4.4, 4.5 Feb 16, 2025
@dalexeev dalexeev force-pushed the fix-method-signature-appearance branch 2 times, most recently from 5e6852f to 861d5eb Compare March 30, 2025 19:06
@dalexeev dalexeev marked this pull request as ready for review March 30, 2025 19:16
@dalexeev dalexeev force-pushed the fix-method-signature-appearance branch from 861d5eb to fbede89 Compare June 23, 2025 16:28
@dalexeev dalexeev changed the title Fix method signature appearance in various places GDScript: Fix call hint appearance for complex callees Jun 23, 2025
@Mickeon Mickeon requested a review from HolonProduction June 23, 2025 17:36
Copy link
Member

@vnen vnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Repiteo Repiteo merged commit 6277e9d into godotengine:master Jun 24, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 24, 2025

Thanks!

@dalexeev dalexeev deleted the fix-method-signature-appearance branch June 24, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants