C#: Resolve the hostfxr path using dotnet CLI #96146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer this PR with #81266 to avoid hardcoding non-standard hostfxr locations. |
This was referenced Dec 6, 2024
|
#81266 was merged, so this could now be rebased / retested and should be mergeable. |
Instead of trying to get the location of the dotnet CLI from PATH (which is unavailable in some platforms that don't allow reading environment variables), we execute the dotnet CLI to list the available SDKs and find the hostfxr location that way.
raulsntos
force-pushed
the
dotnet/resolve-hostfxr-path-from-command-line
branch
from
4b660a4 to
5a2c033
Compare
akien-mga
approved these changes
Jun 9, 2025
AThousandShips
approved these changes
Jun 9, 2025
Comment on lines
+131
to
+132
| String version_string = sdk.get_slice(" ", 0); | ||
| String path = sdk.get_slice(" ", 1); |
There was a problem hiding this comment.
Suggested change
| String version_string = sdk.get_slice(" ", 0); | |
| String path = sdk.get_slice(" ", 1); | |
| String version_string = sdk.get_slicec(' ', 0); | |
| String path = sdk.get_slicec(' ', 1); |
There was a problem hiding this comment.
Sorry, I didn't get a chance to make the change before the PR got merged.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying to get the location of the dotnet CLI from PATH (which is unavailable in some platforms that don't allow reading environment variables), we execute the dotnet CLI to list the available SDKs and find the hostfxr location that way.