Skip to content

Fix resetting imported scene parameters to default. #98014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SaracenOne
Copy link
Member

Closes #98013

Fixes scene subresource property not being updated if
all properties are reset to default in advanced importer settings.
@SaracenOne SaracenOne added this to the 4.4 milestone Oct 9, 2024
@SaracenOne SaracenOne requested a review from a team as a code owner October 9, 2024 12:16
@SaracenOne SaracenOne changed the title Fix resetting imported scene paramters to default. Fix resetting imported scene parameters to default. Oct 9, 2024
@Repiteo Repiteo modified the milestones: 4.4, 4.5 Feb 24, 2025
Copy link
Contributor

@lyuma lyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple bugfix, got forgotten in 4.4 cycle but let's get it in for 4.5.

Test case: Open advanced importer, click a node like Skeleton3D, select Skip Import. Reimport. Before this fix, it is impossible to disable Skip Import. After this fix, disabling Skip Import works fine.

@akien-mga akien-mga merged commit a3d297a into godotengine:master Jun 10, 2025
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@lyuma lyuma added cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release topic:editor topic:import
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import options do not change if all options get reset to default.
4 participants