cmake, diagnose, rpc: Backport #2788 and #2786 to hotfix #2794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"find_package(Boost CONFIG)" finds the upstream package directly, without the find module. BoostConfig.cmake package configuration file is provided since Boost 1.70, so earlier versions couldn't be found.
Disable MSYS2 job because there are no trivial ways to install older Boost. Conflicts: .github/workflows/cmake-ci.yml
`boost::asio::ip::tcp::resolver::query` has been removed in 1.87 which causes compilation issues. This raises the minimum supported version of Boost to 1.66 which should be safe since near-EOL focal has 1.71.
`boost::asio::ip::tcp::resolver::iterator` has been removed in Boost 1.87.
I'm at a loss for words.
|
Why are we doing this PR? The PR's in question have already been merged and are in the testnet branch for a release, which is imminent. No backport is necessary. |
|
Sorry, wasn't aware of the release schedule. Mostly I just wanted to have the (at time of writing) current release buildable on my system and I may have jumped the gun a little. |
|
That's ok. Thanks for going through the effort. You are welcome in the meantime to build and run your local hotfix branch on which this PR derives. This will be a production compatible release then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 5.4.8.0-hotfix-1 does not build on Arch with the latest updates. This PR backports PRs #2788 and #2786 to allow building on an updated Arch linux build.
Compiles, passes tests, and runs on my machine.