Skip to content

cmake, diagnose, rpc: Backport #2788 and #2786 to hotfix #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rpc: remove deprecated resolver::query
`boost::asio::ip::tcp::resolver::query` has been removed in 1.87 which
causes compilation issues.

This raises the minimum supported version of Boost to 1.66 which should
be safe since near-EOL focal has 1.71.
  • Loading branch information
div72 authored and 2001herne committed Feb 10, 2025
commit 76ef32beb366c7977236c0358a68c6d3826f4c32
3 changes: 1 addition & 2 deletions src/rpc/protocol.h
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,7 @@ class SSLIOStreamDevice : public boost::iostreams::device<boost::iostreams::bidi
bool connect(const std::string& server, const std::string& port)
{
boost::asio::ip::tcp::resolver resolver(GetIOService(stream));
boost::asio::ip::tcp::resolver::query query(server.c_str(), port.c_str());
boost::asio::ip::tcp::resolver::iterator endpoint_iterator = resolver.resolve(query);
boost::asio::ip::tcp::resolver::iterator endpoint_iterator = resolver.resolve(server, port);
boost::asio::ip::tcp::resolver::iterator end;
boost::system::error_code error = boost::asio::error::host_not_found;
while (error && endpoint_iterator != end)
Expand Down