-
Notifications
You must be signed in to change notification settings - Fork 9.5k
Tech debt: Use AutoFlEx for auditmanager
#42741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
% AUDITMANAGER_DEREGISTER_ACCOUNT_ON_DESTROY=1 make testacc TESTARGS='-run=TestAccAuditManagerAccountRegistration_serial' PKG=auditmanager make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.2 test ./internal/service/auditmanager/... -v -count 1 -parallel 20 -run=TestAccAuditManagerAccountRegistration_serial -timeout 360m -vet=off 2025/05/16 14:56:38 Creating Terraform AWS Provider (SDKv2-style)... 2025/05/16 14:56:38 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccAuditManagerAccountRegistration_serial === PAUSE TestAccAuditManagerAccountRegistration_serial === CONT TestAccAuditManagerAccountRegistration_serial === RUN TestAccAuditManagerAccountRegistration_serial/basic === RUN TestAccAuditManagerAccountRegistration_serial/disappears === RUN TestAccAuditManagerAccountRegistration_serial/kms_key --- PASS: TestAccAuditManagerAccountRegistration_serial (66.31s) --- PASS: TestAccAuditManagerAccountRegistration_serial/basic (13.23s) --- PASS: TestAccAuditManagerAccountRegistration_serial/disappears (14.47s) --- PASS: TestAccAuditManagerAccountRegistration_serial/kms_key (38.61s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/auditmanager 71.050s % AWS_DEFAULT_REGION=us-east-2 make testacc TESTARGS='-run=TestAccAuditManagerAssessmentDelegation_' PKG=auditmanager ACCTEST_PARALLELISM=3 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.2 test ./internal/service/auditmanager/... -v -count 1 -parallel 3 -run=TestAccAuditManagerAssessmentDelegation_ -timeout 360m -vet=off 2025/05/19 09:23:53 Creating Terraform AWS Provider (SDKv2-style)... 2025/05/19 09:23:53 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccAuditManagerAssessmentDelegation_basic === PAUSE TestAccAuditManagerAssessmentDelegation_basic === RUN TestAccAuditManagerAssessmentDelegation_disappears === PAUSE TestAccAuditManagerAssessmentDelegation_disappears === RUN TestAccAuditManagerAssessmentDelegation_optional === PAUSE TestAccAuditManagerAssessmentDelegation_optional === RUN TestAccAuditManagerAssessmentDelegation_multiple === PAUSE TestAccAuditManagerAssessmentDelegation_multiple === CONT TestAccAuditManagerAssessmentDelegation_basic === CONT TestAccAuditManagerAssessmentDelegation_optional === CONT TestAccAuditManagerAssessmentDelegation_multiple --- PASS: TestAccAuditManagerAssessmentDelegation_multiple (21.38s) === CONT TestAccAuditManagerAssessmentDelegation_disappears --- PASS: TestAccAuditManagerAssessmentDelegation_basic (23.25s) --- PASS: TestAccAuditManagerAssessmentDelegation_optional (39.85s) --- PASS: TestAccAuditManagerAssessmentDelegation_disappears (20.78s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/auditmanager 46.854s
% AWS_DEFAULT_REGION=us-east-2 make testacc TESTARGS='-run=TestAccAuditManagerAssessmentReport_' PKG=auditmanager ACCTEST_PARALLELISM=3 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.2 test ./internal/service/auditmanager/... -v -count 1 -parallel 3 -run=TestAccAuditManagerAssessmentReport_ -timeout 360m -vet=off 2025/05/19 09:47:11 Creating Terraform AWS Provider (SDKv2-style)... 2025/05/19 09:47:11 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccAuditManagerAssessmentReport_basic === PAUSE TestAccAuditManagerAssessmentReport_basic === RUN TestAccAuditManagerAssessmentReport_disappears === PAUSE TestAccAuditManagerAssessmentReport_disappears === RUN TestAccAuditManagerAssessmentReport_optional === PAUSE TestAccAuditManagerAssessmentReport_optional === CONT TestAccAuditManagerAssessmentReport_basic === CONT TestAccAuditManagerAssessmentReport_optional === CONT TestAccAuditManagerAssessmentReport_disappears --- PASS: TestAccAuditManagerAssessmentReport_basic (23.65s) --- PASS: TestAccAuditManagerAssessmentReport_disappears (23.85s) --- PASS: TestAccAuditManagerAssessmentReport_optional (40.81s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/auditmanager 45.498s
% AWS_DEFAULT_REGION=us-east-2 make testacc TESTARGS='-run=TestAccAuditManagerFrameworkShare_' PKG=auditmanager ACCTEST_PARALLELISM=2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.2 test ./internal/service/auditmanager/... -v -count 1 -parallel 2 -run=TestAccAuditManagerFrameworkShare_ -timeout 360m -vet=off 2025/05/19 10:38:56 Creating Terraform AWS Provider (SDKv2-style)... 2025/05/19 10:38:56 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccAuditManagerFrameworkShare_basic === PAUSE TestAccAuditManagerFrameworkShare_basic === RUN TestAccAuditManagerFrameworkShare_disappears === PAUSE TestAccAuditManagerFrameworkShare_disappears === RUN TestAccAuditManagerFrameworkShare_optional === PAUSE TestAccAuditManagerFrameworkShare_optional === CONT TestAccAuditManagerFrameworkShare_basic === CONT TestAccAuditManagerFrameworkShare_optional --- PASS: TestAccAuditManagerFrameworkShare_basic (12.78s) === CONT TestAccAuditManagerFrameworkShare_disappears --- PASS: TestAccAuditManagerFrameworkShare_optional (27.46s) --- PASS: TestAccAuditManagerFrameworkShare_disappears (20.26s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/auditmanager 37.860s
% AUDITMANAGER_ORGANIZATION_ADMIN_ACCOUNT_ID=... AWS_DEFAULT_REGION=us-east-2 make testacc TESTARGS='-run=TestAccAuditManagerOrganizationAdminAccountRegistration_serial' PKG=auditmanager make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.2 test ./internal/service/auditmanager/... -v -count 1 -parallel 20 -run=TestAccAuditManagerOrganizationAdminAccountRegistration_serial -timeout 360m -vet=off 2025/05/19 11:20:59 Creating Terraform AWS Provider (SDKv2-style)... 2025/05/19 11:20:59 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccAuditManagerOrganizationAdminAccountRegistration_serial === PAUSE TestAccAuditManagerOrganizationAdminAccountRegistration_serial === CONT TestAccAuditManagerOrganizationAdminAccountRegistration_serial === RUN TestAccAuditManagerOrganizationAdminAccountRegistration_serial/basic === RUN TestAccAuditManagerOrganizationAdminAccountRegistration_serial/disappears --- PASS: TestAccAuditManagerOrganizationAdminAccountRegistration_serial (25.46s) --- PASS: TestAccAuditManagerOrganizationAdminAccountRegistration_serial/basic (13.67s) --- PASS: TestAccAuditManagerOrganizationAdminAccountRegistration_serial/disappears (11.78s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/auditmanager 30.303s
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
# Conflicts: # internal/service/auditmanager/account_registration.go # internal/service/auditmanager/account_registration_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
The
auditmanager
service was one of the first to useterraform-plugin-framework
, before the introduction of AutoFlEx.This PR refactors to use AutoFlEx.
Relates #38907.
Output from Acceptance Testing