Skip to content

chore: Update FDv2 state format to use parentheses instead of square brackets #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Update FDv2 state format to use parentheses instead of square brackets

This PR updates the FDv2 state (sometimes called basis) format to use parentheses () instead of square brackets [] as specified in SDK-1242.

Changes

  • Updated all instances of FDv2 state/basis format in test helper files to use parentheses instead of square brackets

Testing

  • Manually verified all instances were updated correctly

Link to Devin run

https://app.devin.ai/sessions/c69d5325edd94bc1a46c08582f55cd69

Requested by: [email protected]

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner May 9, 2025 19:26
Copy link
Contributor Author

Original prompt from [email protected]:

Received message in Slack channel #sdk-tools:

@Devin we recently made a change to the FDv2 protocol. Can you update the specs for this in the sdk-specs repository? The FDv2 state (sometimes called basis), no longer uses square brackets [] and instead will use parenthesis (). Please update accordingly and make a PR under mk/sdk-1242/tournament-brackets

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@keelerm84 keelerm84 changed the title Update FDv2 state format to use parentheses instead of square brackets chore: Update FDv2 state format to use parentheses instead of square brackets May 12, 2025
@keelerm84 keelerm84 merged commit f4b1589 into v7 May 12, 2025
18 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-1242/tournament-brackets branch May 12, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants