Skip to content

chore: Update FDv2 state format to use parentheses instead of square brackets #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

chore: Update FDv2 state format to use parentheses instead of square brackets #265

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cef5151
Update FDv2 state format to use parentheses instead of square brackets
devin-ai-integration[bot] May 9, 2025
c7f9676
Merge branch 'v7' into mk/sdk-1242/tournament-brackets
keelerm84 May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'v7' into mk/sdk-1242/tournament-brackets
  • Loading branch information
@keelerm84
keelerm84 authored May 12, 2025
commit c7f96766d948ca5c1544286dfddafa0259e078a1
4 changes: 2 additions & 2 deletions testhelpers/ldservicesv2/streaming_protocol_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ func (f *StreamingProtocol) WithDeleteObject(object subsystems.DeleteObject) *St
// WithTransferred adds a PayloadTransferred event to the protocol with a given version. The state is an arbitrary
// placeholder string; if tests are added that need to verify properties related to the state, this can be
// updated.
func (f *StreamingProtocol) WithTransferred(version int) *StreamingProtocol {
return f.pushEvent(subsystems.NewSelector("(p:17YNC7XBH88Y6RDJJ48EKPCJS7:53)", version))
func (f *StreamingProtocol) WithTransferred(state string, version int) *StreamingProtocol {
return f.pushEvent(subsystems.NewSelector(state, version))
}

// WithPutObjects adds multiple PutObject events to the protocol.
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.