Skip to content

feat: Add support for an identify queue. #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

kinyoklion
Copy link
Member

No description provided.

Copy link
Contributor

github-actions bot commented May 1, 2025

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 23840 bytes
Compressed size limit: 25000
Uncompressed size: 116116 bytes

throw e;
},
);
return identifyPromise.then(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I try to avoid promise chaining, but in this PR it is used to make it clear where things are happening synchronously. We synchronously return this promise that has some chaining that will resolve at some point. We don't actually want to await any of the process inside this method.

Copy link
Contributor

github-actions bot commented May 2, 2025

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 21059 bytes
Compressed size limit: 25000
Uncompressed size: 72155 bytes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to a factory to save a few bytes.

Copy link
Contributor

github-actions bot commented May 2, 2025

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 17158 bytes
Compressed size limit: 20000
Uncompressed size: 86612 bytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant