-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Add support for an identify queue. #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@launchdarkly/js-sdk-common size report |
throw e; | ||
}, | ||
); | ||
return identifyPromise.then( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I try to avoid promise chaining, but in this PR it is used to make it clear where things are happening synchronously. We synchronously return this promise that has some chaining that will resolve at some point. We don't actually want to await any of the process inside this method.
@launchdarkly/js-client-sdk size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to a factory to save a few bytes.
@launchdarkly/js-client-sdk-common size report |
No description provided.