Skip to content

feat: Add support for an identify queue. #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jun 10, 2025
Merged

feat: Add support for an identify queue. #842

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
8b24438
chore: Add implementation for async task queue.
kinyoklion Apr 30, 2025
7f5fd64
Lint
kinyoklion Apr 30, 2025
6891c52
More tests.
kinyoklion Apr 30, 2025
fcf0990
Clarify comment.
kinyoklion Apr 30, 2025
178973b
WIP
kinyoklion Apr 30, 2025
efec1ef
Lint and test.
kinyoklion May 1, 2025
d311964
Add identifyResult method.
kinyoklion May 1, 2025
75a9cea
Merge branch 'main' into rlamb/emsr-86/implement-client-side-identify
kinyoklion May 1, 2025
b6fac89
Revert unneeded change from test file.
kinyoklion May 1, 2025
e9c62f7
Remove browser client facade.
kinyoklion May 1, 2025
f0d08b6
Add implementation comment.
kinyoklion May 1, 2025
d5331e8
Sheddable.
kinyoklion May 2, 2025
9c48c5b
Log as well as throw.
kinyoklion May 2, 2025
c0dbad1
Check size impact of a factory instead of a class.
kinyoklion May 2, 2025
4f22426
Lint
kinyoklion May 2, 2025
3955464
Update size limit and report.
kinyoklion May 2, 2025
98f7746
WIP
kinyoklion May 7, 2025
c49d936
Linting
kinyoklion May 13, 2025
286b0ee
Merge branch 'main' into rlamb/emsr-86/implement-client-side-identify
kinyoklion May 21, 2025
3d8157f
Support before/after identify with identify queue.
kinyoklion May 21, 2025
27bbb0a
Merge branch 'main' into rlamb/emsr-86/implement-client-side-identify
kinyoklion May 21, 2025
6db624d
Add another test.
kinyoklion May 21, 2025
958ec8f
Lint
kinyoklion May 21, 2025
6d436ae
Update packages/shared/sdk-client/src/api/LDIdentifyOptions.ts
kinyoklion Jun 9, 2025
157e366
Change context parameter name.
kinyoklion Jun 9, 2025
2ff703d
Merge branch 'main' into rlamb/emsr-86/implement-client-side-identify
kinyoklion Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify comment.
  • Loading branch information
@kinyoklion
kinyoklion committed Apr 30, 2025
commit fcf099069872bf60a9feb21abdef78a0ab38496e
2 changes: 1 addition & 1 deletion packages/shared/sdk-client/src/async/AsyncTaskQueue.ts
View file
Open in desktop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to a factory to save a few bytes.

Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export class AsyncTaskQueue<TTaskResult> {

/**
* Returns the number of pending tasks in the queue.
* Intended for use for testing purposes only.
* Intended for testing purposes only.
*
* @internal
* @returns The number of pending tasks in the queue.
Expand Down