[mlir][ROCDL] Remove unneeded bf16 expansion in LowerGPUToROCDL #139603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The umbrella pass fol lowering GPU ops to ROCDL (aka lowering to LLVM + the AMDGPU-specific setup) would call the arith patterns that manually implemented extf and truncf on bfloat because the LLVM AMDGPU backend used to not suppport those operaitons. Since the backend does now support these operations and has for quite some time, remove these patterns from the default lowering flow.
krzysz00
changed the title
|
@llvm/pr-subscribers-mlir Author: Krzysztof Drewniak (krzysz00) ChangesThe umbrella pass fol lowering GPU ops to ROCDL (aka lowering to LLVM
Since the backend does now support these operations and has for quite some time, remove these patterns from the default lowering flow. Full diff: https://github.com/llvm/llvm-project/pull/139603.diff 1 Files Affected:
diff --git a/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp b/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
index dd16ec4b73e9f..c52bf505de4a5 100644
--- a/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
+++ b/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
@@ -319,7 +319,6 @@ struct LowerGpuOpsToROCDLOpsPass final
{
RewritePatternSet patterns(ctx);
populateGpuRewritePatterns(patterns);
- arith::populateExpandBFloat16Patterns(patterns);
(void)applyPatternsGreedily(m, std::move(patterns));
}
|
|
@llvm/pr-subscribers-mlir-gpu Author: Krzysztof Drewniak (krzysz00) ChangesThe umbrella pass fol lowering GPU ops to ROCDL (aka lowering to LLVM
Since the backend does now support these operations and has for quite some time, remove these patterns from the default lowering flow. Full diff: https://github.com/llvm/llvm-project/pull/139603.diff 1 Files Affected:
diff --git a/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp b/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
index dd16ec4b73e9f..c52bf505de4a5 100644
--- a/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
+++ b/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
@@ -319,7 +319,6 @@ struct LowerGpuOpsToROCDLOpsPass final
{
RewritePatternSet patterns(ctx);
populateGpuRewritePatterns(patterns);
- arith::populateExpandBFloat16Patterns(patterns);
(void)applyPatternsGreedily(m, std::move(patterns));
}
|
umangyadav
reviewed
May 12, 2025
| @@ -319,7 +319,6 @@ struct LowerGpuOpsToROCDLOpsPass final | |||
| { | |||
| RewritePatternSet patterns(ctx); | |||
| populateGpuRewritePatterns(patterns); | |||
| arith::populateExpandBFloat16Patterns(patterns); | |||
There was a problem hiding this comment.
Looks good to me, but looks like i don't have "approval" access
tgymnich
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The umbrella pass fol lowering GPU ops to ROCDL (aka lowering to LLVM
Since the backend does now support these operations and has for quite some time, remove these patterns from the default lowering flow.