Skip to content

[mlir][ROCDL] Remove unneeded bf16 expansion in LowerGPUToROCDL #139603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[mlir][ROCDL] Remove unneeded bf16 expansion in LowerGPUToRocdl
The umbrella pass fol lowering GPU ops to ROCDL (aka  lowering to LLVM
+ the AMDGPU-specific setup) would call the arith patterns that
manually implemented extf and truncf on bfloat because the LLVM AMDGPU
backend used to not suppport those operaitons.

Since the backend does now support these operations and has for quite
some time, remove these patterns from the default lowering flow.
  • Loading branch information
krzysz00 committed May 12, 2025
commit fc1843a519c3f42c4f66924777c66d29495758ec
1 change: 0 additions & 1 deletion mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,6 @@ struct LowerGpuOpsToROCDLOpsPass final
{
RewritePatternSet patterns(ctx);
populateGpuRewritePatterns(patterns);
arith::populateExpandBFloat16Patterns(patterns);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but looks like i don't have "approval" access

(void)applyPatternsGreedily(m, std::move(patterns));
}

Expand Down