Skip to content

Add pure mode #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Add pure mode #1815

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9299471
core: add compatibility mode setter for system
julianoes Mar 7, 2022
cdf7df6
action: only switch to Hold for PX4
julianoes Mar 8, 2022
c431ded
action: update reboot and shutdown command
julianoes Mar 8, 2022
8834fd8
action: make param thread-safe (drive-by)
julianoes Mar 8, 2022
0da1ef7
action: add note regarding landing altitude
julianoes Mar 8, 2022
304daf8
action: add todo to improve API (drive-by)
julianoes Mar 8, 2022
4ac541b
action: mark hack for takeoff altitude
julianoes Mar 8, 2022
f369152
action: auto change mode for REPOSITION
julianoes Mar 8, 2022
b8190a2
action: only attempt ORBIT against PX4
julianoes Mar 8, 2022
c4e4eca
action: always use callback queue (drive-by)
julianoes Mar 8, 2022
938e855
calibration: return unsupported if not using PX4
julianoes Mar 8, 2022
9e70c7c
calibration: clang-tidy and other fixes (drive-by)
julianoes Mar 8, 2022
6c548af
failure: only set param for PX4
julianoes Mar 8, 2022
8a91a49
follow_me: use existing ms method (drive-by)
julianoes Mar 8, 2022
92c529b
follow_me: clang-tidy suggestions (drive-by)
julianoes Mar 8, 2022
122cfb9
info: remove unused include (drive-by)
julianoes Mar 9, 2022
dc9da9d
mission_raw: disable mission_changed in pure mode
julianoes Mar 9, 2022
539f9bb
offboard: use existing MAVLink masks (drive-by)
julianoes Mar 9, 2022
8ffd92c
telemetry: only use param fallback for PX4
julianoes Mar 15, 2022
45c2e13
Fixes after rebase
julianoes Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
calibration: clang-tidy and other fixes (drive-by)
  • Loading branch information
@julianoes
julianoes committed Nov 22, 2022
commit 9e70c7c11d4bbd18be48b1da16b16521f1463e1e
2 changes: 1 addition & 1 deletion src/mavsdk/plugins/calibration/calibration_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ void CalibrationImpl::calibrate_gyro_async(const CalibrationCallback& callback)
void CalibrationImpl::call_callback(
const CalibrationCallback& callback,
const Calibration::Result& result,
const Calibration::ProgressData progress_data)
const Calibration::ProgressData& progress_data)
{
if (callback) {
_parent->call_user_callback(
Expand Down
11 changes: 1 addition & 10 deletions src/mavsdk/plugins/calibration/calibration_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class CalibrationImpl : public PluginImplBase {
void call_callback(
const CalibrationCallback& callback,
const Calibration::Result& result,
const Calibration::ProgressData progress_data);
const Calibration::ProgressData& progress_data);

void receive_statustext(const MavlinkStatustextHandler::Statustext&);

Expand All @@ -47,7 +47,6 @@ class CalibrationImpl : public PluginImplBase {

void report_started();
void report_done();
void report_warning(const std::string& warning);
void report_failed(const std::string& failed);
void report_cancelled();
void report_progress(float progress);
Expand All @@ -57,14 +56,6 @@ class CalibrationImpl : public PluginImplBase {

mutable std::mutex _calibration_mutex{};

bool _is_gyro_ok = false;
bool _is_accelerometer_ok = false;
bool _is_magnetometer_ok = false;

std::atomic<bool> _is_gyro_running = {false};
std::atomic<bool> _is_accelerometer_running = {false};
std::atomic<bool> _is_magnetometer_running = {false};

enum class State {
None,
GyroCalibration,
Expand Down