make the failing tests on e2e actually pass #2486
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to make failing end‐to‐end tests pass by clearly indicating command failures through updated workflow scripts. Key changes include injecting evalScript commands and runFlow blocks into multiple YAML test files and updating config file paths in the test runner script.
- Added explicit evalScript and runFlow commands to simulate failure and recovery in test flows.
- Modified configuration paths in the test runner (e2e/run_tests) to reflect updated file structure.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/workspaces/demo_app/fail_visible_extended.yaml | Inserts a runFlow block with pre/post evalScript commands. |
| e2e/workspaces/demo_app/fail_visible.yaml | Similar changes using assertVisible command within runFlow. |
| e2e/workspaces/demo_app/fail_not_found.yaml | Uses tapOn command with runFlow alterations to simulate failure. |
| e2e/workspaces/demo_app/fail_launchApp_nonDefault.yaml | Runs launchApp with specific non-default app id via runFlow. |
| e2e/workspaces/demo_app/fail_launchApp.yaml | Updates the launchApp command and evalScript commands in runFlow. |
| e2e/workspaces/demo_app/fail_fast.yaml | Adds assertTrue based flow handling with a note on unreachable code. |
| e2e/run_tests | Adjusts config file paths for both passing and failing test runs. |
Fishbowler
requested changes
May 14, 2025
Co-authored-by: Dan Caseley <[email protected]>
Co-authored-by: Dan Caseley <[email protected]>
Co-authored-by: Dan Caseley <[email protected]>
Co-authored-by: Dan Caseley <[email protected]>
Co-authored-by: Dan Caseley <[email protected]>
Co-authored-by: Dan Caseley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(because we want them to pass by showing the actual command failed)