Skip to content

make the failing tests on e2e actually pass #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

make the failing tests on e2e actually pass #2486

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
45de01b
make the failing tests on e2e actually pass
herval May 14, 2025
d2f4b36
Update e2e/workspaces/demo_app/fail_fast.yaml
herval May 15, 2025
1c00b8d
Update e2e/workspaces/demo_app/fail_launchApp_nonDefault.yaml
herval May 15, 2025
7ac2a8c
Update e2e/workspaces/demo_app/fail_launchApp.yaml
herval May 15, 2025
e578206
Update e2e/workspaces/demo_app/fail_not_found.yaml
herval May 15, 2025
7bf667a
Update e2e/workspaces/demo_app/fail_visible_extended.yaml
herval May 15, 2025
4befc9e
Update e2e/workspaces/demo_app/fail_visible.yaml
herval May 15, 2025
109fdcf
fail is fail, pass is pass
herval May 15, 2025
efbc3b5
another expected fail
herval May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update e2e/workspaces/demo_app/fail_launchApp.yaml 
Co-authored-by: Dan Caseley <[email protected]>
  • Loading branch information
@herval @Fishbowler
herval and Fishbowler committed May 16, 2025
commit 7ac2a8c350c6042b69bbaaae38900e3c731e55b6
2 changes: 1 addition & 1 deletion e2e/workspaces/demo_app/fail_launchApp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ tags:
commands:
- launchApp
- evalScript: ${output.didFail = 0}
- evalScript: ${output.didFail = 1}
- assertTrue: ${output.didFail == 1}