chore: remove deprecated framework info package #6446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrstork
changed the title
mrstork
changed the title
mrstork
force-pushed
the
remove-deprecated-framework-info
branch
2 times, most recently
from
e770709 to
ab0b45a
Compare
mrstork
commented
Jun 10, 2025
| @@ -133,6 +133,7 @@ | |||
| "ava": "^5.0.0", | |||
| "c8": "^10.0.0", | |||
| "cpy": "^11.0.0", | |||
| "cpy-cli": "^5.0.0", | |||
serhalp
reviewed
Jun 10, 2025
serhalp
reviewed
Jun 10, 2025
There was a problem hiding this comment.
🚀 wow, thanks for taking this over!
alternatively for the weird remix/hydrogen thing, I wonder if we should just start with a PR that deletes that code? It's a hacky untested workaround for something that should no longer be relevant (non-Vite Remix and non-Vite Hydrogen) and it appears to be the source of a more relevant bug with Vite Hydrogen. Thoughts?
5 tasks
mrstork
force-pushed
the
remove-deprecated-framework-info
branch
from
ab0b45a to
33d1f63
Compare
mrstork
force-pushed
the
remove-deprecated-framework-info
branch
from
33d1f63 to
4e92367
Compare
|
This pull request adds or modifies JavaScript ( |
serhalp
approved these changes
Jun 10, 2025
|
This pull request adds or modifies JavaScript ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recreating #5819
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)