Added error handling for division by zero #255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gill003
commented
Nov 1, 2024
| @@ -2,12 +2,21 @@ | |||
|
|
|||
| public class Division { | |||
|
|
|||
| //Function which checks if the divisor is equal to 0 to avoid division by zero. | |||
| private static void checkDivisor(int b) { | |||
There was a problem hiding this comment.
Function which takes in the divisor as a parameter.
| @@ -2,12 +2,21 @@ | |||
|
|
|||
| public class Division { | |||
|
|
|||
| //Function which checks if the divisor is equal to 0 to avoid division by zero. | |||
| private static void checkDivisor(int b) { | |||
| if (b == 0) { | |||
There was a problem hiding this comment.
Checks if the divisor is 0 and then throws an IllegalArgumentException if true.
| public static final long division(int a, int b) { | ||
| checkDivisor(b); |
There was a problem hiding this comment.
Run the checkDivisor function and send the divisor as the parameter in every function that does division
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a checkdivisor function in Division.java which takes in an argument and checks if it is equal to 0, if it is then it throws an IllegalArgumentException. I call this function in every division function with the divisor as the parameter. These changes ensure that the code doesn't have any issues when dividing by zero.
By submitting this pull request I confirm I've read and complied with the below requirements.
Added {Algorithm/DS name} [{Language}], notUpdate README.mdorAdded new code.