Skip to content

Added error handling for division by zero #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/com/jwetherell/algorithms/mathematics/Division.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,21 @@

public class Division {

//Function which checks if the divisor is equal to 0 to avoid division by zero.
private static void checkDivisor(int b) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function which takes in the divisor as a parameter.

if (b == 0) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks if the divisor is 0 and then throws an IllegalArgumentException if true.

throw new IllegalArgumentException("Divisor cannot be zero.");
}
}

public static final long division(int a, int b) {
checkDivisor(b);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run the checkDivisor function and send the divisor as the parameter in every function that does division

long result = ((long) a) / ((long) b);
return result;
}

public static final long divisionUsingLoop(int a, int b) {
checkDivisor(b);
int absA = Math.abs(a);
int absB = Math.abs(b);

Expand All @@ -22,6 +31,7 @@ public static final long divisionUsingLoop(int a, int b) {
}

public static final long divisionUsingRecursion(int a, int b) {
checkDivisor(b);
int absA = Math.abs(a);
int absB = Math.abs(b);

Expand All @@ -38,6 +48,7 @@ public static final long divisionUsingRecursion(int a, int b) {
}

public static final long divisionUsingMultiplication(int a, int b) {
checkDivisor(b);
int absA = Math.abs(a);
int absB = Math.abs(b);

Expand All @@ -55,6 +66,7 @@ public static final long divisionUsingMultiplication(int a, int b) {
}

public static final long divisionUsingShift(int a, int b) {
checkDivisor(b);
int absA = Math.abs(a);
int absB = Math.abs(b);
int tempA, tempB, counter;
Expand All @@ -76,6 +88,7 @@ public static final long divisionUsingShift(int a, int b) {
}

public static final long divisionUsingLogs(int a, int b) {
checkDivisor(b);
long absA = Math.abs(a);
long absB = Math.abs(b);
double logBase10A = Math.log10(absA);
Expand Down