This repository was archived by the owner on Jul 1, 2022. It is now read-only.
Feature/fra #34
Merged
Feature/fra #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, merged. I'd like to cut down on the number of actions and have more generic "run command"/"run drush command" actions and make the commands configurable, but that would require quite some refactoring, so it's something for v2. |
|
I agree regarding the configurable generic commands. Thanks! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - I had a use case for reverting all features before an updb and cc all. I'm not sure if the contrib space fits into the scope of the project. No worries if not.
One issue in the validate methond is that 'fra' still outputs messages unless drush_invoke_process sets backend_options to FALSE. The 'drush' method on Action would have to allow overriding that. Or maybe the validate method is overkill altogether.
Thanks.
-Rick