Skip to content

Fix JSB+GPIO CMakeLists and dependencies #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented May 25, 2025

https://build.ros2.org/job/Rbin_uN64__joint_state_broadcaster__ubuntu_noble_amd64__binary/115/console

16:05:19 CMake Error at CMakeLists.txt:39 (target_link_libraries):
16:05:19   Target "joint_state_broadcaster" links to:
16:05:19 
16:05:19     controller_manager::controller_manager
16:05:19 
16:05:19   but the target was not found.  Possible reasons include:
16:05:19 
16:05:19     * There is a typo in the target name.
16:05:19     * A find_package call is missing for an IMPORTED target.
16:05:19     * An ALIAS target is missing.

We don't need to link the CM here? But only in the tests.
And we don't need rcutils in this repo?

@christophfroehlich christophfroehlich changed the title Fix JSB CMakeLists Fix JSB+GPIO CMakeLists and dependencies May 25, 2025
Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.69%. Comparing base (097e94d) to head (bd11b29).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1705   +/-   ##
=======================================
  Coverage   85.69%   85.69%           
=======================================
  Files         123      123           
  Lines       11896    11895    -1     
  Branches     1015     1014    -1     
=======================================
  Hits        10194    10194           
  Misses       1379     1379           
+ Partials      323      322    -1     
Flag Coverage Δ
unittests 85.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit a37b52e into master May 26, 2025
24 of 27 checks passed
@christophfroehlich christophfroehlich deleted the fix/jsb/rolling branch May 26, 2025 06:23
mergify bot pushed a commit that referenced this pull request May 26, 2025
christophfroehlich added a commit that referenced this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants