Skip to content

Fix steering_controllers_library docs and msg field #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025

Conversation

christophfroehlich
Copy link
Contributor

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.74%. Comparing base (4612b48) to head (ad333de).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1733      +/-   ##
==========================================
- Coverage   85.74%   85.74%   -0.01%     
==========================================
  Files         123      123              
  Lines       11916    11915       -1     
  Branches     1017     1017              
==========================================
- Hits        10217    10216       -1     
  Misses       1377     1377              
  Partials      322      322              
Flag Coverage Δ
unittests 85.74% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roller/test/test_ackermann_steering_controller.cpp 100.00% <100.00%> (ø)
...ntroller/test/test_bicycle_steering_controller.cpp 100.00% <ø> (ø)
...llers_library/src/steering_controllers_library.cpp 70.37% <100.00%> (ø)
...troller/test/test_tricycle_steering_controller.cpp 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Christoph Fröhlich <[email protected]>
@bmagyar
Copy link
Member

bmagyar commented Jun 5, 2025

please merge when the semi-binary CI is happy

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@bmagyar bmagyar merged commit ee2843a into master Jun 5, 2025
19 of 27 checks passed
@bmagyar bmagyar deleted the fix/steering_docs branch June 5, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bicycle_steering_controller] Wrong command return
3 participants